Add two unit tests for join method #615
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review! |
adnanhemani
requested changes
Oct 6, 2024
| @@ -44,6 +44,7 @@ def test_setup_map(): | |||
| 'width': 960, | |||
| 'height': 500, | |||
| 'features': [], | |||
| 'attr':'Map tiles by Stamen Design, CC BY 3.0 - Map data © OpenStreetMap' | |||
| @@ -56,6 +57,7 @@ def test_setup_map(): | |||
| ds.Marker(51.514, -0.139), | |||
| ds.Marker(51.519, -0.132) | |||
| ]), | |||
| 'attr':'Map tiles by Stamen Design, CC BY 3.0 - Map data © OpenStreetMap' | |||
| @@ -1660,6 +1665,21 @@ def test_join_without_other_label(table, table2): | |||
| 2 | c | 3 | two | |||
| """) | |||
|
|
|||
| def test_join_with_empty_table(table, empty_table): | |||
| result = empty_table._join('points', table) | |||
There was a problem hiding this comment.
While I think you're testing the right things - testing the internal methods (denoted with the underscore at the beginning) is not a standard practice. I think this could be a good PR if you did these same tests using the "join" method.
|
Closing PR as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two unit tests to improve the test coverage of the join method in test_tables.py